Support hash algorithm option. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `messageDigestAlgorithm` option to API. - Add support for SHA-256, SHA-384, and SHA-512 name variations to `MessageDigests`. - Updates tests to handle `hashAlgorithm` option if present.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## add-signal-support #78 +/- ##
======================================================
- Coverage 93.71% 93.59% -0.13%
======================================================
Files 10 10
Lines 605 609 +4
======================================================
+ Hits 567 570 +3
- Misses 38 39 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messageDigestAlgorithmoption to API.MessageDigests.hashAlgorithmoption if present.There may be a better way to handle the algorithm string normalization. This works for now. Node uses "sha384", WebCrypto uses "SHA-384", and the test suite uses "SHA384".