Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get credential status add parameter status type #5

Merged
merged 17 commits into from
Mar 10, 2022

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Feb 23, 2022

Addresses:

#4
#3

@aljones15 aljones15 self-assigned this Feb 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #5 (d62b1a6) into main (7b132ec) will decrease coverage by 6.57%.
The diff coverage is 81.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   98.11%   91.53%   -6.58%     
==========================================
  Files           3        3              
  Lines         106      130      +24     
==========================================
+ Hits          104      119      +15     
- Misses          2       11       +9     
Impacted Files Coverage Δ
main.js 90.75% <81.63%> (-7.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b132ec...d62b1a6. Read the comment docs.

@aljones15 aljones15 marked this pull request as ready for review March 7, 2022 15:22
@aljones15 aljones15 requested review from dlongley and JSAssassin and removed request for dlongley March 7, 2022 15:22
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have time to do a super detailed review here, hopefully tests will cover things. It does look like it checks every found status and reports a status match if at least one is found as well. Thanks!

main.js Outdated Show resolved Hide resolved
main.js Outdated Show resolved Hide resolved
main.js Outdated Show resolved Hide resolved
@aljones15 aljones15 merged commit 9e76455 into main Mar 10, 2022
@aljones15 aljones15 deleted the getCredentialStatus-add-parameter-statusType branch March 10, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants