fix warnings

digitalcoleman · Jul 1, 2021 · 89c6f04 · 89c6f04
1 parent 36cedce
commit 89c6f04
Show file tree

Hide file tree

Showing 9 changed files with 31 additions and 15 deletions.
diff --git a/src/components/Breadcrumbs.js b/src/components/Breadcrumbs.js
@@ -1,5 +1,5 @@
 import React, { memo } from 'react';
-import { useLocalization, LocalizedLink as Link } from 'gatsby-theme-i18n';
+import { LocalizedLink as Link } from 'gatsby-theme-i18n';
 import classnames from 'classnames';
 
 import { titleCase } from '../utils';

diff --git a/src/components/Button.js b/src/components/Button.js
@@ -32,6 +32,7 @@ export const Button = ({
           className={classNames}
           href={href}
           target={target}
+          rel={target === '_blank' ? 'noreferrer' : null}
           tabIndex={tabIndex ? tabIndex : 0}>
           {children}
         </a>

diff --git a/src/components/Navbar.js b/src/components/Navbar.js
@@ -135,7 +135,7 @@ const Navbar = ({ siteTitle, scrolled }) => {
                 })}>
                 {item.href ? (
                   item.href.startsWith('https') ? (
-                    <a target="_blank" href={item.href}>
+                    <a target="_blank" rel="noreferrer" href={item.href}>
                       {intl.formatMessage({ id: item.name })}
                     </a>
                   ) : (

diff --git a/src/components/Topbar.js b/src/components/Topbar.js
@@ -50,9 +50,12 @@ const Topbar = ({ show }) => {
             </li>
           ))}
         </ul>
-        {/* <LanguageSelector
-          className={classnames(css.languageSelector, grid.col)}
-        />*/}
+        {/* disabled until we have a second language */}
+        {false && (
+          <LanguageSelector
+            className={classnames(css.languageSelector, grid.col)}
+          />
+        )}
       </div>
     </div>
   );

diff --git a/src/components/sketch/Sketch.js b/src/components/sketch/Sketch.js
@@ -5,8 +5,6 @@ import SketchGraphic from './SketchGraphic';
 import SketchCode from './SketchCode';
 import Button from '../Button';
 
-import { localStorage } from '../../utils';
-
 import css from './Sketch.module.css';
 import grid from '../../styles/grid.module.css';
 

diff --git a/src/hooks/examples.js b/src/hooks/examples.js
@@ -124,5 +124,5 @@ export const useTrail = (example) => {
     }
 
     return trail;
-  }, []);
+  }, [intl, example]);
 };
diff --git a/src/hooks/reference.js b/src/hooks/reference.js
@@ -215,5 +215,5 @@ export const useTrail = (libraryName, category, subcategory, classanchor) => {
     }
 
     return trail;
-  }, [intl, libraryName]);
+  }, [intl, libraryName, classanchor, category, subcategory]);
 };
diff --git a/src/hooks/tutorials.js b/src/hooks/tutorials.js
@@ -7,6 +7,7 @@ import { useIntl } from 'react-intl';
 **/
 export const useTrail = (example) => {
   const intl = useIntl();
+
   return useMemo(() => {
     return [
       intl.formatMessage({ id: 'learn' }),
@@ -19,5 +20,5 @@ export const useTrail = (example) => {
         label: intl.formatMessage({ id: 'textTutorials' })
       }
     ];
-  }, []);
+  }, [intl]);
 };
diff --git a/src/pages/index.js b/src/pages/index.js
@@ -186,32 +186,45 @@ const IndexPage = ({ data }) => {
               <li>
                 <a
                   target="_blank"
+                  rel="noreferrer"
                   href="https://www.creativeapplications.net/category/processing/">
                   Creative Applications
                 </a>
               </li>
               <li>
-                <a target="_blank" href="https://openprocessing.org/">
+                <a
+                  target="_blank"
+                  rel="noreferrer"
+                  href="https://openprocessing.org/">
                   OpenProcessing
                 </a>
               </li>
               <li>
-                <a target="_blank" href="https://fyprocessing.tumblr.com/">
+                <a
+                  target="_blank"
+                  rel="noreferrer"
+                  href="https://fyprocessing.tumblr.com/">
                   For your Processing
                 </a>
               </li>
               <li>
-                <a target="_blank" href="https://www.reddit.com/r/processing/">
+                <a
+                  target="_blank"
+                  rel="noreferrer"
+                  href="https://www.reddit.com/r/processing/">
                   Processing Subreddit
                 </a>
               </li>
               <li>
-                <a target="_blank" href="https://vimeo.com/groups/processing">
+                <a
+                  target="_blank"
+                  rel="noreferrer"
+                  href="https://vimeo.com/groups/processing">
                   Vimeo
                 </a>
               </li>
               <li>
-                <a target="_blank" href="http://sketchpad.cc/">
+                <a target="_blank" rel="noreferrer" href="http://sketchpad.cc/">
                   Studio Sketchpad
                 </a>
               </li>