Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: children of page endpoint #17

Closed
Tracked by #97
svenseeberg opened this issue Oct 25, 2018 · 8 comments
Closed
Tracked by #97

API: children of page endpoint #17

svenseeberg opened this issue Oct 25, 2018 · 8 comments
Labels
🍺 hackathon Task that can be done in a hackathon 💡 feature New feature or request
Milestone
Stable release

Comments

@svenseeberg
Copy link
Member

svenseeberg commented Oct 25, 2018 •
edited

Endpoint to get all children of a page. This must be compatible to Integreat API v3.

https://github.com/Integreat/cms/wiki/REST-APIv3-Documentation#children-of-a-post

@maxammann @Simple-codinger is this used by any current app? Otherwise this can be moved to another milestone.
@svenseeberg svenseeberg added the 💡 feature New feature or request label Oct 25, 2018
@svenseeberg svenseeberg added this to the Proof of Feasability milestone Oct 25, 2018
@maxammann
Copy link
Member

It's currently not used, but I would suggest to rethink the api and provide a different api for offline content loading and progressive content loading in the webapp.

@maxammann maxammann mentioned this issue Oct 25, 2018
Closed
@svenseeberg
Copy link
Member Author

svenseeberg commented Oct 25, 2018 •
edited

We still need to implement at least the API v3, maybe even the v0 to 2. We can discuss a newer API later.

@vincentgierisch
Copy link

vincentgierisch commented Oct 25, 2018 •
edited

For full backwards compatibility we also have to implement v0.

@svenseeberg
Copy link
Member Author

svenseeberg commented Oct 25, 2018 •
edited

@Simple-codinger basically I agree. Can you provide information about how many installed apps are using which API version? We have ~9 months until the CMS switch. This could be enough time for deprecating the old API.

@vincentgierisch
Copy link

Currently all of the devices are using APIv0 because we still have some issues remaining in the APIv3 Branch

@maxammann
Copy link
Member

to be discussed in gdoc

@svenseeberg svenseeberg mentioned this issue Jan 11, 2019
Closed
23 tasks
@timobrembeck timobrembeck removed this from the Proof of Feasability milestone Mar 16, 2019
@svenseeberg svenseeberg added the 🍺 hackathon Task that can be done in a hackathon label May 10, 2019
@svenseeberg svenseeberg added this to the Feature Completion milestone Jun 7, 2019
svenseeberg added a commit that referenced this issue Nov 20, 2019
@svenseeberg
# This is a combination of 18 commits.
dd05fda 
# This is the 1st commit message:

Add mirror page helper functions, fixes #13

# This is the commit message #2:

Add mirrored page to page edit template

# This is the commit message #3:

Naming convention, add PageTranslation property

# This is the commit message #4:

Save mirrored page user input

# This is the commit message #5:

Add AJAX URL

# This is the commit message #6:

progress with ajax

# This is the commit message #7:

AJAX call and response

# This is the commit message #8:

Correct AJAX parameters and response

# This is the commit message #9:

Working selects

# This is the commit message #10:

Update POT

# This is the commit message #11:

Remove serializers import

# This is the commit message #12:

Update po file

# This is the commit message #13:

Fix empty value

# This is the commit message #14:

Do not require mirrored region select

# This is the commit message #15:

Hidden div

# This is the commit message #16:

clean up po

# This is the commit message #17:

Move JS code outside of permissions conditional

# This is the commit message #18:

Transmit all info
@svenseeberg
Copy link
Member Author

So we decided that this is not immediately necessary as there are no plans to change the API in the foreseeable future.

@svenseeberg svenseeberg modified the milestones: Backlog, Version 1.0 Nov 10, 2021
@svenseeberg
Copy link
Member Author

Its now being used, but probably already implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍺 hackathon Task that can be done in a hackathon 💡 feature New feature or request
Projects
None yet
Milestone
Stable release
Development

No branches or pull requests
4 participants
@maxammann @vincentgierisch @svenseeberg @timobrembeck