Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: parents endpoint #19

Closed
Tracked by #97
svenseeberg opened this issue Oct 25, 2018 · 6 comments · Fixed by #1096
Closed
Tracked by #97

API: parents endpoint #19

svenseeberg opened this issue Oct 25, 2018 · 6 comments · Fixed by #1096
Assignees
@svenseeberg
Labels
‼️ prio: high Needs to be resolved ASAP. 🍺 hackathon Task that can be done in a hackathon 💡 feature New feature or request
Milestone
Stable release

Comments

@svenseeberg
Copy link
Member

svenseeberg commented Oct 25, 2018 •
edited

Endpoint to get parents of a page up to the root. This must be compatible to Integreat API v3.

https://github.com/Integreat/cms/wiki/REST-APIv3-Documentation#parents-of-a-post

@maxammann @Simple-codinger is this used by any app? Otherwise we could move this to another milestone.
@svenseeberg svenseeberg added the 💡 feature New feature or request label Oct 25, 2018
@svenseeberg svenseeberg added this to the Proof of Feasability milestone Oct 25, 2018
@maxammann
Copy link
Member

See: #17

@sascha11110 sascha11110 changed the title API: parents endpint API: parents endpoint Oct 26, 2018
@svenseeberg svenseeberg mentioned this issue Jan 11, 2019
Closed
23 tasks
@timobrembeck timobrembeck removed this from the Proof of Feasability milestone Mar 16, 2019
@svenseeberg svenseeberg added the 🍺 hackathon Task that can be done in a hackathon label May 10, 2019
@svenseeberg svenseeberg added this to the Feature Completion milestone Jun 7, 2019
@svenseeberg
Copy link
Member Author

So we decided that this is not immediately necessary as there are no plans to change the API in the foreseeable future.

@ulliholtgrave ulliholtgrave added the ⁉️ prio: low Not urgent, can be resolved in the distant future. label Jan 6, 2022
@ulliholtgrave
Copy link
Member

@klinzo Is this endpoint in any way relevant for the app anymore?

@steffenkleinle
Copy link
Member

steffenkleinle commented Jan 6, 2022 •
edited

@ulliholtgrave Yes, it is used in the web app and therefore absolutely crucial. Without it, the webapp won't work.

E.g. this site https://webnext.integreat.app/augsburg/en/work-and-education uses this request https://cms-test.integreat-app.de/augsburg/en/wp-json/extensions/v3/parents?&url=/augsburg/en/work-and-education

@ulliholtgrave
Copy link
Member

Good to know 🙈

@ulliholtgrave ulliholtgrave modified the milestones: Backlog, Version 1.0 Jan 6, 2022
@svenseeberg svenseeberg added ‼️ prio: high Needs to be resolved ASAP. and removed ⁉️ prio: low Not urgent, can be resolved in the distant future. labels Jan 6, 2022
@steffenkleinle
Copy link
Member

steffenkleinle commented Jan 6, 2022 •
edited

There is also a sentry report for this: https://sentry.tuerantuer.org/organizations/digitalfabrik/issues/416/?query=is%3Aunresolved

svenseeberg added a commit that referenced this issue Jan 6, 2022
@svenseeberg
APIv3: add parents/ancestors end point, fixes #19
a31d362
@svenseeberg svenseeberg mentioned this issue Jan 6, 2022
Merged
svenseeberg added a commit that referenced this issue Jan 10, 2022
@svenseeberg @timobrembeck
APIv3: add parents/ancestors end point, fixes #19
77953f6 
Co-authored-by: Timo Ludwig <ludwig@integreat-app.de>
ulliholtgrave added a commit that referenced this issue Jan 11, 2022
@ulliholtgrave
Merge pull request #1096 from digitalfabrik/feature/api-parents-endpoint
425c365 
APIv3: add parents/ancestors end point, fixes #19
@timobrembeck timobrembeck mentioned this issue Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svenseeberg svenseeberg

Labels
‼️ prio: high Needs to be resolved ASAP. 🍺 hackathon Task that can be done in a hackathon 💡 feature New feature or request
Projects
None yet
Milestone
Stable release
Development

Successfully merging a pull request may close this issue.

APIv3: add parents/ancestors end point, fixes #19 digitalfabrik/integreat-cms
5 participants
@maxammann @svenseeberg @ulliholtgrave @timobrembeck @steffenkleinle