Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editor shortcuts for our custom icons #1957

Closed
ulliholtgrave opened this issue Dec 9, 2022 · 2 comments · Fixed by #1962
Closed

Add editor shortcuts for our custom icons #1957

ulliholtgrave opened this issue Dec 9, 2022 · 2 comments · Fixed by #1962
Assignees
@muddi900
Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h
Milestone
22Q4

Comments

@ulliholtgrave
Copy link
Member

Motivation

I noticed that it seems to be pretty easy to define shortcuts (e.g. Alt+I+1) for own functions inside the TinyMCE and I also received some feature requests by municipalities for this. As this isn't a big change and probably benefits some municipalities a lot, I would think of it as a "quick win" that we should implement rather sooner then later.

Proposed Solution

Add the TinyMCE in-built shortcuts to our addIcon functionality. See. https://www.tiny.cloud/blog/creating-keyboard-shortcuts-tinymce/
@ulliholtgrave ulliholtgrave added 💡 feature New feature or request 🍼 good first issue Good for newcomers ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h labels Dec 9, 2022
@ulliholtgrave ulliholtgrave added this to the 22Q4 milestone Dec 9, 2022
@muddi900
Copy link
Contributor

muddi900 commented Dec 9, 2022

So does this mean the app should look for any un-listed icons in the svg folded and add them? Or you give users a popup to upload an svg file?

@JoeyStk
Copy link
Contributor

JoeyStk commented Dec 9, 2022 •
edited

Hi @muddi900, thank you for your interest in our project. Our editor has several custom icons which can be inserted and for them we want to use shortcuts so the users of our CMS can easily access them (See screenshot for how the icons are currently being input)
image

muddi900 added a commit to muddi900/integreat-cms that referenced this issue Dec 10, 2022
@muddi900
[Issue digitalfabrik#1957] added keyboard shortcuts for icons in the …
c8aabd3 
…editor
@muddi900 muddi900 mentioned this issue Dec 10, 2022
Merged
muddi900 added a commit to muddi900/integreat-cms that referenced this issue Dec 13, 2022
@muddi900
[Issue digitalfabrik#1957] added keyboard shortcuts for icons in the …
d4dd327 
…editor

refactored the insert icon flow and replace addIcon with the refactored flow for shortcuts. Also added th the refactored to addIcon
muddi900 added a commit to muddi900/integreat-cms that referenced this issue Dec 13, 2022
@muddi900
[Issue digitalfabrik#1957] added keyboard shortcuts for icons in the …
225e6a6 
…editor

refactored the insert icon flow and replace addIcon with the refactored flow for shortcuts. Also added th the refactored to addIcon

added change to unreleased features
timobrembeck pushed a commit to muddi900/integreat-cms that referenced this issue Dec 18, 2022
@muddi900 @timobrembeck
[Issue digitalfabrik#1957] added keyboard shortcuts for icons in the …
db3221b 
…editor

refactored the insert icon flow and replace addIcon with the refactored flow for shortcuts. Also added th the refactored to addIcon

added change to unreleased features
@svenseeberg svenseeberg mentioned this issue Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muddi900 muddi900

Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ❗ prio: medium Should be scheduled in the forseeable future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Milestone
22Q4
Development

Successfully merging a pull request may close this issue.

Add keyboard shortcuts for icons in the editor muddi900/integreat-cms
3 participants
@ulliholtgrave @muddi900 @JoeyStk