Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts for icons in the editor #1962

Merged

Conversation

muddi900
Copy link
Contributor

Short description

Add shortcuts for Adding icons in the editor.

Proposed changes

  • Pressing Alt+|+<number> would insert the corresponding icons
  • The sequence corresponds to the sequence in menu. eg. 1 for pin, 2 for www, etc.

Side effects

  • None

Resolved issues

Fixes: #1957


Pull Request Review Guidelines

@muddi900 muddi900 requested a review from a team as a code owner December 10, 2022 08:47
Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulation for your first PR in our repository 🎉 It's almost there 😃

Additionaly to the suggestion in the code, I would like you to add an entry into CHANGELOG file under UNRELEASED.

integreat_cms/static/src/js/forms/tinymce-init.ts Outdated Show resolved Hide resolved
Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Thank you 😃

After squashing the commits (and resolving conflicts if any occurs) I think this PR is ready to be merged 👍

Copy link
Contributor

@PeterNerlich PeterNerlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, works as expected. Congrats!

Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, really cool feature! 👍

After squashing the commits

I agree, could you execute:

git rebase --interactive HEAD~2

and replace the second "pick" by "fixup" and save?
Then, you'd have to do:

git push --force-with-lease

To overwrite the existing commits.

Additionaly to the suggestion in the code, I would like you to add an entry into CHANGELOG file under UNRELEASED.

Again, I agree, and this change has not yet been addressed.
Could you add the lines:

* [ [#1957](https://github.com/digitalfabrik/integreat-cms/issues/1957) ] Add keyboard shortcuts for icons in the editor

to the CHANGELOG.md into the UNRELEASED section?

- Refactor the insert icon flow
- Replace addIcon with the refactored flow for shortcuts
@timobrembeck timobrembeck changed the title [Issue #1957] added keyboard shortcuts for icons in the editor Add keyboard shortcuts for icons in the editor Dec 18, 2022
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍
I rebased your branch one last time and cleaned up the git history, now I think this is good to go! 🎉

(One optional idea I had was to somehow document this possibility, otherwise users don't know the keyboard combinations for the icons, but I guess we can also put this in our usage wiki.)

@timobrembeck timobrembeck merged commit 45a836a into digitalfabrik:develop Dec 18, 2022
@muddi900 muddi900 deleted the feature/custom-shortcut-icon branch December 20, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add editor shortcuts for our custom icons
4 participants