Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow machine translation from German if the HIX value is high enough #2130

Closed
Tracked by #1928
charludo opened this issue Mar 20, 2023 · 1 comment · Fixed by #2158
Closed
Tracked by #1928

Only allow machine translation from German if the HIX value is high enough #2130

charludo opened this issue Mar 20, 2023 · 1 comment · Fixed by #2158
Assignees
@charludo
Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ☺️ effort: low Should be doable in <4h 🆘 prio: urgent Needs to be resolved now(?)
Milestone
23Q1

Comments

@charludo
Copy link
Contributor

charludo commented Mar 20, 2023 •
edited by timobrembeck

Motivation

We want to prevent the automatic translation of hard to understand page texts from German into other languages. Therefore, only allow machine translations from German if the HIX value of that page is >= 15.

Note this does not affect POIs and Events, and neither does it affect MT from other languages.

Proposed Solution

Check if the source language is not German or has a high enough HIX value when attempting to translate from German via the "Automatic Translation" checkbox from #1875.

Additionally, hide the checkbox if those conditions apply.

Alternatives

Since this depends on

but the MT feature is due to go live on 01.04.2023, if both issues cannot be completed by then, instead completely disable MT for pages with source language German as a temporary measure and do this issue ASAP in Q2.

Additional Context

Design Requirements
@charludo charludo added 💡 feature New feature or request ☺️ effort: low Should be doable in <4h 🆘 prio: urgent Needs to be resolved now(?) labels Mar 20, 2023
@charludo charludo added this to the 23Q1 milestone Mar 20, 2023
@charludo
Copy link
Contributor Author

It is probably easiest to implement these checks in the mt_is_permitted utility function, this way removing the checkbox and actually enforcing the rule can be done in one step.

@charludo charludo added the 🍼 good first issue Good for newcomers label Mar 20, 2023
@charludo charludo mentioned this issue Mar 20, 2023
Open
62 tasks
@charludo charludo self-assigned this Mar 22, 2023
@charludo charludo mentioned this issue Mar 24, 2023
Merged
@charludo charludo linked a pull request Mar 24, 2023 that will close this issue
Only allow machine translation if the HIX value is high enough #2158
Merged
@ulliholtgrave ulliholtgrave mentioned this issue Apr 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charludo charludo

Labels
🍼 good first issue Good for newcomers 💡 feature New feature or request ☺️ effort: low Should be doable in <4h 🆘 prio: urgent Needs to be resolved now(?)
Projects
None yet
Milestone
23Q1
Development

Successfully merging a pull request may close this issue.

Only allow machine translation if the HIX value is high enough digitalfabrik/integreat-cms
1 participant
@charludo