Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox Automatic translation for outdated translation on page form #1875

Closed
Tracked by #1928 ...
ulliholtgrave opened this issue Nov 18, 2022 · 12 comments · Fixed by #2062
Closed
Tracked by #1928 ...

Add checkbox Automatic translation for outdated translation on page form #1875

ulliholtgrave opened this issue Nov 18, 2022 · 12 comments · Fixed by #2062
Assignees
Labels
‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request 😅 effort: medium Should be doable in <12h
Milestone

Comments

@ulliholtgrave
Copy link
Member

ulliholtgrave commented Nov 18, 2022

Motivation

In the daily work of the municipalities the normal workflow includes updating the german content and directly wanting to translate them to other languages. Therefore, our automatic translation workflow should include a possibility to trigger automatic translations directly in the page form for now outdated translation.

Proposed Solution

Add another checkbox below/above (TBD) "minor_edit" that is exclusive to "minor_edit". If it is checked and the page gets updated, all translations that would be outdated and are supported by DeepL are automatically translated.

The result would be a manual created german translation and up-to-date translations in other languages.

The translation budget needs to be considered for the translation.

Additional Context

Related to:

This blocks:

@ulliholtgrave ulliholtgrave added 💡 feature New feature or request ‼️ prio: high Needs to be resolved ASAP. 😅 effort: medium Should be doable in <12h labels Nov 18, 2022
@ulliholtgrave ulliholtgrave added this to the 22Q4 milestone Nov 18, 2022
@timobrembeck timobrembeck changed the title Add checkbox Automatische Übersetzung für veraltete Übersetzung for automatic translation on page form Add checkbox Automatic translation for outdated translation on page form Nov 18, 2022
@nikolahoff
Copy link

@ulliholtgrave if the budget for translations is not sufficient is it possible
a) to show an info: "Your budget is not sufficient. You want to translate 123 words but you only have credits for 56 words."
b) to disable the "Update" button in that case?

@ulliholtgrave
Copy link
Member Author

@nikolahoff Yes, this is possible.

However, We should consider the case when a user is trying to translate into 5 languages but his budget only allows translations for 3. In this case we would stop the translation process after 3 and inform the user about 2 missing languages due to insufficient funds. Does that sound like a reasonable solution for you?

@nikolahoff
Copy link

Sounds good. Can we show an info-box in that case?

@ulliholtgrave
Copy link
Member Author

Yes, My suggestion would be a redirect to the current page and an info message on the top describing the issue and a list of skipped translations.

@osmers
Copy link

osmers commented Dec 1, 2022

@ulliholtgrave @nikolahoff how do we deal with the possible issue that Kommunen will call us and say that, had they known, they would have chosen different languages to translate the text into? Not sure how probably this is, since the budgets should be large enough. Just wanted to alert to the possibility...maybe we can stop the process before anything is translated, saying that the budget would only be large enough for x languages, and to please go to the settings and choose the ones they want?

@ulliholtgrave
Copy link
Member Author

ulliholtgrave commented Dec 1, 2022

@osmers I guess we addressed this with the priority setting, right? If we set up the automatic translation for them we should highlight the reason for this setting and they should think about how they want to configure their AT process. However, I guess we can still add a warning if they try to translate more text then their budget (with the possibility to abort the process).

@osmers
Copy link

osmers commented Dec 1, 2022

@ulliholtgrave maybe @dkehne can give his input here bcs he was not a fan of our prioritising - it would be too confusing.

@timobrembeck
Copy link
Member

We're talking about a single page here, right?
I doubt that the difference between one single page being translated into language X but not into language Y makes such a huge difference.
If they really cannot live with a partially translated page, they can also manually copy the content into the DeepL UI to finish the missing languages by hand.
I doubt the programming effort is justified by such an edge case which does not have drastic implications.

@charludo charludo self-assigned this Dec 7, 2022
@osmers
Copy link

osmers commented Dec 12, 2022

I doubt the programming effort is justified by such an edge case which does not have drastic implications.

Makes sense - let's keep it simple then. Might be something we need to fix in case it happens often, but I highly doubt it. In theory at least, the 50.000 words should be enough to translate Aktualisierungen.

@osmers
Copy link

osmers commented Mar 7, 2023

@charludo maybe you can post the current design here for the checkbox and explain the idea of language selection?

@charludo
Copy link
Contributor

charludo commented Mar 7, 2023

@osmers yes, here's the current state:

  1. initial situation when opening a page(/event/poi) in the editor:
    image

  2. checking "automatic translation" opens this form:
    image

By default, only existing translations are checked (the behaviour originally requested in this issue), but the user has the option to also create new, non-existent translations.

@osmers
Copy link

osmers commented Mar 8, 2023

Thanks a lot - that looks very cool I think :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
‼️ prio: high Needs to be resolved ASAP. 💡 feature New feature or request 😅 effort: medium Should be doable in <12h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants