Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes language tabs, fixes #1030 #1050

Closed
wants to merge 1 commit into from
Closed

Changes language tabs, fixes #1030 #1050

wants to merge 1 commit into from

Conversation

JoeyStk
Copy link
Contributor

@JoeyStk JoeyStk commented Dec 4, 2021

Short description

This PR changes the look and function of the language tabs.

Proposed changes

So there are four things I changed in order to find a solution. All of this is up for discussion, of course. I just wanted to show you some ideas of what I think can be fixed.

  • Change the order of the language row. Maybe this make a lot of sense - or just makes sense, when there are more than one row. But in case of more than one rows the active tab would be in the bottom row, which is the Windows solutions.
  • Change the background color to blue for non-active tabs, change the background-color to white for active tabs. That way it seems like the active tab is merging into the content-card. This is the most common solution I found when I was googling reference for tabs.
  • Add some margin, so the tabs don't overlap
  • Change the active effect to look more like the hover effect.

I'm aware that all of the proposed changes are just quick fixes for now. For a more sustainable solution in the long run it might be a good idea to involve someone from UI/UX here.
Maybe we should have a discussion about this in the Mattermost channel. I wasn't sure what the common procedure with such issues is.

Looking forward for ideas and feedback!

Fixes: #1030

@JoeyStk JoeyStk requested a review from a team December 4, 2021 18:52
@ulliholtgrave
Copy link
Member

Hey Johannes, Thank you for your effort, but I think that we'll want to do a little bit more in this field. I talked with Nikola about this and we had some ideas, how we want to change this. I tried to put my ideas in the related issue and did some "mockup" with my limited design skills :D

@JoeyStk JoeyStk closed this Dec 16, 2021
@JoeyStk JoeyStk deleted the bug/languages branch January 4, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language tabs scale poorly
2 participants