Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language tabs scale poorly #1030

Closed
timobrembeck opened this issue Nov 23, 2021 · 2 comments · Fixed by #1078
Closed

Language tabs scale poorly #1030

timobrembeck opened this issue Nov 23, 2021 · 2 comments · Fixed by #1078
Assignees
Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future.

Comments

@timobrembeck
Copy link
Member

Describe the Bug

Our language tab design doesn't scale well if the number of languages is increasing or the screen size is small.

Screenshot 2021-11-23 at 19-22-46 Integreat Redaktionssystem

Expected Behavior

I see three main problems:

  • The "Version" link should not cause the language tabs to float. Instead, we should maybe move it back into the white box to the rest of the form?
  • Tabs in the second row should expand until the form-box (so no light blue background should be visible between the tabs and the box). But not sure whether that's doable, since the space underneath is in theory taken by the following flex items...
  • If a tab in the top row is selected, it shouldn't have a bottom white border (because this causes it to "melt" into the bottom tab which makes no sense - the idea was that it should "melt" into the box itself). But no idea whether we can safely detect whether a tab is in the top bar or the bottom bar, since it's just one flexbox...

Actual Behavior

Everything looks weird

Additional Information

@timobrembeck timobrembeck added 🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future. labels Nov 23, 2021
@timobrembeck timobrembeck added this to the Version 1.1 milestone Nov 23, 2021
@JoeyStk JoeyStk self-assigned this Dec 2, 2021
JoeyStk added a commit that referenced this issue Dec 4, 2021
@ulliholtgrave
Copy link
Member

Together with UI/UX, I have created a small draft for a redesign of the language selection. From a total of 5 languages, the other languages should be available in a drop-down (similar to the tree structure). The languages should be sorted according to their status, so that it is easier for the user to get translations that still need work. In addition, the current translation, e.g. in ours, should be marked in dark blue. The versions should also be moved out of the UI area and back into the status box.

Page-ui

@JoeyStk
Copy link
Contributor

JoeyStk commented Dec 13, 2021

This what I have tried up until this point:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⁉️ prio: low Not urgent, can be resolved in the distant future.
Projects
None yet
4 participants