Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance for poi views #1081

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

david-venhoff
Copy link
Member

Short description

This pr improves the performance of poi views.
Co-authored-by: philip popien membralala@users.noreply.github.com

Proposed changes

  • Load poi translations in one query
  • Load the current language just once

@david-venhoff david-venhoff requested a review from a team as a code owner January 4, 2022 19:20
@david-venhoff david-venhoff force-pushed the feature/improve_poi_performance branch from af6f956 to 158bd53 Compare January 5, 2022 09:44
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!
Could you resolve the conflicts, fix the translations and make the commit message more meaningful? Then this is ready to merge if you don't see any other potential for improvement.

@david-venhoff david-venhoff force-pushed the feature/improve_poi_performance branch from 158bd53 to 108091f Compare January 5, 2022 10:06
@david-venhoff david-venhoff merged commit 9fc492d into develop Jan 5, 2022
@david-venhoff david-venhoff deleted the feature/improve_poi_performance branch January 5, 2022 10:24
@david-venhoff david-venhoff mentioned this pull request Jan 5, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants