Meta: 📈 Performance

[ulliholtgrave]

Motivation

Our current code basis includes a lot of duplicate calls to our database. They should be removed towards an efficient performance level.

Proposed Solution

Check the following:

• Redundant calls for object properties (e.g. page.default_translation called multiple times)
• Redundant calls for foreign keys (e.g. page.translations.X ... e.g. page.translations.Y in the same model)
• Redundant calls for methods with the same arguments (e.g. get_translation('de') ... get_translations('de'))

For more insight into the topic, you might want to read: https://docs.djangoproject.com/en/3.2/topics/performance/

For the following models the views, templates, models and api should be examined. Furthermore, their respective occurrence in utils should be investigated.

• chat (An idea could be removing the 'chat_last_visited' from the user model and put this in a cookie. Edit: This is probably a bad idea, since many users might delete their cookies after closing the browser. See https://github.com/Integreat/integreat-cms/blob/04b6a165e6afa8ab9313650c7803ed648d94417a/src/cms/models/users/user.py#L42)
• events (Timo) Improve performance of page tree #1088
• feedback (David, Mizuki & Philip) Improve performance for feedback views #1089
• languages & language tree (Guiliano) Enhances language tree performance #966
• media (Ulli)
• offers (Philip)
• pages (Timo) Improve performance of page tree #1088
• pois (David, Mizuki & Philip) Improve performance for poi views #1081
• push_notifications (only solved partially) Improve performance for push notification #1113
• regions (Ulli) Improve region performance #1022
• users, roles & organizations (Sven) Optimize user, role and organizations SQL queries #948
• Page form (Timo) Improve forms #1116
• Event form (Timo) Improve forms #1116
• POI form (Timo) Improve forms #1116
• Translation Coverage (David) Reduce queries for translation coverage to a constant amount #1137
• Ajax content search (David) Improve performance of content searches #1145

[svenseeberg]

FYI: one quick way to display executed SQL queries is adding a a logger to the settings.py:

        "django.db.backends": {
            "level": "DEBUG",
            "handlers": [],
        },

[membralala]

FYI: A while ago I closed #944 without further ado, however meanwhile I found, that there are some cases, where there are duplicated queries in the same call. In this cases it seems, that using djangos @cached_property fixes this and even reduces the loading times, when redis is active.

[ulliholtgrave]

We may consider to cache the result or Matomo requests

[svenseeberg]

@ulliholtgrave I removed the "statistics" from the list as we do not have any relevant database calls in our CMS regarding statistics. Right? This issue is then basically "done". We also do not have any performance issues right now.