Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve revision view #1675

Merged
merged 3 commits into from
Sep 10, 2022
Merged

Improve revision view #1675

merged 3 commits into from
Sep 10, 2022

Conversation

timobrembeck
Copy link
Member

Short description

A few improvements for the revision view

Proposed changes

  • Give more detailed feedback about the current state
  • Add possibility to reject pending reviews
  • Add possibility to discard auto saves
  • Improve button naming when restoring versions
  • Update author when restoring old versions

Resolved issues

Fixes: #1640
Fixes: #1673

@timobrembeck timobrembeck requested a review from a team as a code owner September 9, 2022 13:45
@codeclimate
Copy link

codeclimate bot commented Sep 9, 2022

Code Climate has analyzed commit e80c3f5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 57.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.3% (0.0% change).

View more on Code Climate.

@timobrembeck timobrembeck force-pushed the feature/improve-revision-view branch 3 times, most recently from 1d11dfa to 05f123a Compare September 9, 2022 22:37
- Give more detailed feedback about the current state
- Add possibility to reject pending reviews
- Add possibility to discard auto saves
- Improve button naming when restoring versions
Copy link
Member

@ulliholtgrave ulliholtgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 😊

@timobrembeck timobrembeck merged commit 49706f7 into develop Sep 10, 2022
@timobrembeck timobrembeck deleted the feature/improve-revision-view branch September 10, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reject revisions Set version author to the author that restores a version and update date
2 participants