Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute sidebar boxes evenly also for pois and events #2019

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

JoeyStk
Copy link
Contributor

@JoeyStk JoeyStk commented Jan 23, 2023

Short description

This PR extends the function to evenly distribute the sidebar boxes for POIs and events

Proposed changes

  • Add the required ids (left-sidebar-column and right-sidebar-column), so that the boxes are evenly distributed between the sidebars

Side effects

I think none

Resolved issues

Fixes: Rest of #1769


Pull Request Review Guidelines

@JoeyStk JoeyStk requested a review from a team as a code owner January 23, 2023 14:24
@timobrembeck timobrembeck linked an issue Jan 23, 2023 that may be closed by this pull request
4 tasks
@JoeyStk JoeyStk force-pushed the feature/evenly_distribute_event_and_poi_sidebars branch from f78b661 to 9f102c2 Compare January 23, 2023 14:25
Copy link
Member

@timobrembeck timobrembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit I find this feature very satisfying 😍

@codeclimate
Copy link

codeclimate bot commented Jan 23, 2023

Code Climate has analyzed commit 9463bbe and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.7% (0.0% change).

View more on Code Climate.

@JoeyStk JoeyStk force-pushed the feature/evenly_distribute_event_and_poi_sidebars branch from 9f102c2 to 9463bbe Compare January 23, 2023 14:36
Copy link
Contributor

@charludo charludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it's super satisfying & kind of amazing how well the free space is utilized now!

@JoeyStk JoeyStk merged commit d6121ca into develop Jan 24, 2023
@JoeyStk JoeyStk deleted the feature/evenly_distribute_event_and_poi_sidebars branch January 24, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evenly distribute form sidebar boxes
3 participants