Fix locations endpoint error when default translation is not public

[seluianova]

Short description

When a region creates a location which is a draft in the default language, but public in other languages, the location API returns an internal server error

Proposed changes

• Disable "Publish" button in POI form for non-default languages, when default translation is not public
• Exclude POIs without public translation in the default language from the locations API response
• Add test data to cover the case

Side effects

Didn't find any

Resolved issues

Fixes: #2097

---

Pull Request Review Guidelines

[codeclimate]

Code Climate has analyzed commit bca8ddb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 83.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.1% (0.0% change).

View more on Code Climate.

[Gaston69]

Sounds good :-).
Peter and me suggest that you wanted to use continue instead of break to skip just the current POI instead of all the following.

[timobrembeck]

Thanks a lot! 👍

This handles the existing incorrectly published translations in a way that prevents the API error, but I would like to add one of the following to make it easier for content creators to understand the change:

1. Either create a migration that unpublishes all translations in this state, otherwise it might be confusing if they see "published" as status but they are not showing up in the app
2. Or add a small warning in the page form view whenever a public location is not visible in the app because of a missing default translation

Apart from that, it raises a small UI/UX problem:

The "draft" button looks exactly like the disabled "update" button. I think this is more the problem of the draft button than of the disabled button, so it's probably fine to merge this PR, but we should find a new color for non-disabled secondary buttons soon.

Edit: I opened a new ticket for this:

• Secondary buttons look exactly like disabled buttons #2170

[seluianova]

Added migration to update POI translation status to DRAFT, if there is no default public translation.
(hope I didn't miss anything, as I couldn't test it on real data).

It raises a small UI/UX problem

I noticed it too, but didn't come up with an idea for improvement.

[timobrembeck]

Thanks a lot! 👍

Other than the performance optimization in the migration, I think this is good to go! 🚀

changes have been addressed

[ulliholtgrave]

Thanks, Works as expected 👍