Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only visible languages in the sitemap index #2301

Merged
merged 1 commit into from
May 30, 2023

Conversation

seluianova
Copy link
Contributor

Short description

Currently, the sitemap index (list of all available sitemaps) also links sitemaps of hidden languages.
Only visible languages should show up there

Proposed changes

  • Use visible_languages instead of active_languages in the sitemap view

Side effects

  • No?

Resolved issues

Fixes: #2293


Pull Request Review Guidelines

@seluianova seluianova requested a review from a team as a code owner May 24, 2023 10:57
@seluianova seluianova linked an issue May 24, 2023 that may be closed by this pull request
@codeclimate
Copy link

codeclimate bot commented May 24, 2023

Code Climate has analyzed commit 0507ca8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 76.3% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I researched for a bit and couldn't find anything on possible side effects, that apply to our situation. Therefore I think this is good to go 👍

@seluianova seluianova merged commit eab7e5c into develop May 30, 2023
5 checks passed
@seluianova seluianova deleted the bugfix/sitemap-hidden-languages branch May 30, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sitemap index lists hidden languages
3 participants