Add multiple Attribute To FormField

[s0kil]

Closes #893

[mpscholten]

Can we also add a note here on how to consume a multi input from the action? I guess it's with paramList, but have not checked it.

[s0kil]

If someone creates a column such as email TEXT[] NOT NULL, meaning an list of emails. Then they probably expect to be able to do this:

renderForm :: Person -> Html
renderForm person = formFor person [hsx|
    {(selectField #email emails) { multiple = True }}
    {submitButton}
|]
    where
        emails :: [Text]
        emails = ["test1@example.com", "test2@example.com", "test3@example.com"]

however, there is a compiler error:

Couldn't match type `SelectValue Text' with `[Text]'
        arising from a use of `selectField'

[s0kil]

It seems the selectField function does not account for multiple selections, or a list of emails.

[amitaibu]

@mpscholten any pointer on how to fix this?

[amitaibu]

Seems the above error is unrelated to the PR. I've tried with https://ihp.digitallyinduced.com/Guide/form.html#select-inputs-with-integers and seem to get a similar error

I think that the problem is that my field is of type [Int] and currently SelectValue knows only how to work with a single value

[mpscholten]

This is not as easy to fix as it sounds.

Basically we'd need to change the data structure for the select field to support multiple values. Right now most form fields use this big FormField data structure.

We would like need to make a specialized SelectField data structure that is then returned by the selectField function. The SelectField then could have support for a list of values.

Not sure if that's worth the trouble for now.

[amitaibu]

Ok, so the current workaround, I guess, would be to use checkboxes as described in https://ihp.digitallyinduced.com/Guide/controller.html#multiple-params-with-same-name-checkboxes

[mpscholten]

Yep that works 👍

[amitaibu]

@mpscholten it might be too complex for my current skills, but maybe I could give it a try, for educational fun 😃

Couple of questions I have:

1. Is it correct that the only diff should be in fieldValue. It should probably be [Text] instead of Text?
2. If so, would we copy the entire FormField, and change only that property, or should we move it to some instance?

If it's more elaborate than that, maybe someone could write down how the types would look, and I'll try to follow from there.

[mpscholten]

Is it correct that the only diff should be in fieldValue. It should probably be [Text] instead of Text?

yep that's basically it :) We need to be careful not to break BC with existing forms, that might actually be a bit tricky (e.g. that bug with the duplicate label field name we had recently on master would likely also be triggered here)

Likely the best way is to just get started and then we'll iterate our way there