Expand docs on Raw SQL Queries #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitaibu
commented
Oct 9, 2021
amitaibu
commented
Oct 9, 2021
Co-authored-by: Marc Scholten <marcphilipscholten@gmail.com>
amitaibu
commented
Oct 10, 2021
| -- Get all Projects | ||
| let table :: Text = "projects" | ||
| -- Use PG.Identifier to prevent SQL injection | ||
| result :: [Project] <- sqlQuery "SELECT * FROM ?" [PG.Identifier table] |
There was a problem hiding this comment.
If you wanted to do SELECT * FROM ? WHERE id = ? how do you pass the params?
There was a problem hiding this comment.
Then I'd do it like this:
let id :: Id Project = ".."
result :: [Project] <- sqlQuery "SELECT * FROM ? WHERE id = ?" (PG.Identifier table, id)
amitaibu
commented
Oct 10, 2021
| do | ||
| -- Get all Projects | ||
| let table :: Text = "projects" | ||
| -- Use PG.Identifier to prevent SQL injection |
There was a problem hiding this comment.
Added a note about SQL injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took me a while to figure how to do it, so might help others/ future me 馃樃