-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Testing docs #1126
Fix Testing docs #1126
Conversation
import IHP.FrameworkConfig (ConfigBuilder(..)) | ||
import IHP.Prelude | ||
import IHP.QueryBuilder (fetch, query) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiler complained fetch
doesn't exist in this package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fetch
functions have moved from IHP.QueryBuilder
to IHP.Fetch
|
||
import Web.Types | ||
import Web.Routes | ||
import Generated.Types | ||
import Main () | ||
|
||
-- a function like this probably already exists in your Config module: | ||
makeConfig :: IO ConfigBuilder | ||
makeConfig = ... | ||
-- makeConfig :: IO ConfigBuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to make it easier to copy/ paste
I'm couldn't install I've shared a workspace. Maybe others could have a look and help find the problem, without needing to install anything locally. (GitPod spinned of https://github.com/gitpod-io/template-ihp) |
|
Here are the steps how I've tried to add hspec
|
Here's a Workspace snapshot, maybe that would work - https://gitpod.io#snapshot/76b48fa0-9e16-49af-8370-1235db2bde39 |
Thanks :)
I'm not aware that hspec is callable from the CLI. In our projects we typically have a Then I run |
Alright, that makes sense. So what commands should we mention in https://ihp.digitallyinduced.com/Guide/testing.html#running-a-test (Running a Test) |
I mean:
And remove the |
|
Yes 馃憤
Should be the same for the actual project itself. Or then we should update the testing docs to make clear that tests should be stored in the |
Yeah, PR is indeed trying to fix the docs 馃樃 . So should I copy the Test/Main.hs from IHP lib? |
Yes that sounds good to me 馃憤 |
Getting closer.. I'm trying to add it here as a playground, but now have
However I couldn't fund |
Should be the same as in
|
Note to self, add comment about
That should become
|
PR is actually outdated with your changes - I was just working on an updated one :) |
Ok, feel free to make a new one 馃憤 |
No description provided.