Improved testing functionality #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main change is that now every test is running inside it's own isolated test database
amitaibu
reviewed
Oct 16, 2021
|
|
||
| -- | Create contexts that can be used for mocking | ||
| mockContext :: (InitControllerContext application) => application -> ConfigBuilder -> IO (MockContext application) | ||
| mockContext application configBuilder = do | ||
| withIHPApp :: (InitControllerContext application) => application -> ConfigBuilder -> (MockContext application -> IO ()) -> IO () |
There was a problem hiding this comment.
Maybe keep the word Mock, so it's clear it's not a real app? withMockedIHPApp
There was a problem hiding this comment.
IMO it's not really mocked anymore as we're now using the real database and action lifecycle for testing
amitaibu
reviewed
Oct 16, 2021
IHP/Test/Mocking.hs
Outdated
| @@ -53,11 +58,13 @@ mockContext application configBuilder = do | |||
| let requestContext = RequestContext | |||
| { request = defaultRequest {vault = sessionVault} | |||
| , requestBody = FormBody [] [] | |||
| , respond = \resp -> pure ResponseReceived | |||
| , respond = undefined | |||
There was a problem hiding this comment.
Is it undefined so it would error out if response is not filled in?
There was a problem hiding this comment.
Fixed now :) Leftover from testing
jyoder
reviewed
Oct 21, 2021
| frameworkConfig@(FrameworkConfig {dbPoolMaxConnections, dbPoolIdleTime, databaseUrl}) <- FrameworkConfig.buildFrameworkConfig configBuilder | ||
| databaseConnection <- connectPostgreSQL databaseUrl | ||
|
|
||
| testDatabase <- Database.createTestDatabase databaseUrl |
There was a problem hiding this comment.
Consider using bracket to ensure things get cleaned up if there is an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is that now every test is running inside it's own isolated test database