Use process over os for backwards compatibility. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
force-pushed
the
asb/issues/76
branch
from
8368f45
to
d6c4a6e
Compare
danaelhe
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oswas added in Node 16. Even though we specify that we run on Node 16 and it is the oldest currently supported release upstream, self-host runners may not be properly configured to provide the same environment as GitHub hosted runners. So this switches to usingprocessfor greater backwards compatibility.The drawback to this approach is that
osreports information about the actual operating system whileprocessreports information about the node binary itself. Though in most cases that should be fine.Closes: #76