Commit
When running clusterlint on Go 1.17, it panics right on startup. The issue is our usage of github.com/mattn/go-isatty (consumed by github.com/fatih/color) which had a bug until [1]. Updating to the latest v0.0.14 release fixes the issue. Also bump the minimum (library) dependency to 1.16 in go.mod since that is the oldest, officially supported Go version. Bumping to 1.17 actually enables us to fix the issue by simply updating to the latest github.com/fatih/color, as opposed to adding an indirect import of github.com/mattn/go-isatty which this change does right now (which I suppose works due to Go 1.17 module management improvements); however, that'd come at the price of breaking compatibility with 1.16 users which is non-ideal. Regardless, update github.com/fatih/color as well while we're here. Also bump the version of the Go image used for testing. [1] mattn/go-isatty#66
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.