Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/sys commit hash to 0f9fa26a #66

Merged
merged 1 commit into from Aug 29, 2021
Merged

Conversation

cookieY
Copy link
Contributor

@cookieY cookieY commented Aug 29, 2021

Fixed go 1.17 panic

fatal error: unexpected signal during runtime execution

Related links golang/go#47279

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Aug 29, 2021

Codecov Report

Merging #66 (ee4b64c) into master (68134e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   44.00%   44.00%           
=======================================
  Files           3        3           
  Lines          75       75           
=======================================
  Hits           33       33           
  Misses         40       40           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68134e7...ee4b64c. Read the comment docs.

@mattn mattn merged commit 504425e into mattn:master Aug 29, 2021
14 checks passed
@mattn
Copy link
Owner

@mattn mattn commented Aug 29, 2021

Thank you

@shoenseiwaso
Copy link

@shoenseiwaso shoenseiwaso commented Sep 7, 2021

@cookieY thanks for the fix and @mattn thanks for merging and for the library! Would you mind pushing a new release so downstream dependencies can also update?

@mattn
Copy link
Owner

@mattn mattn commented Sep 7, 2021

Tagged v0.0.14

@shoenseiwaso
Copy link

@shoenseiwaso shoenseiwaso commented Sep 7, 2021

Thanks @mattn, much appreciated!

timoreimann added a commit to digitalocean/clusterlint that referenced this issue Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The
issue is our usage of github.com/mattn/go-isatty (consumed by
github.com/fatih/color) which had a bug until [1]. Updating to the
latest v0.0.14 release fixes the issue.

[1] mattn/go-isatty#66
timoreimann added a commit to digitalocean/clusterlint that referenced this issue Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The
issue is our usage of github.com/mattn/go-isatty (consumed by
github.com/fatih/color) which had a bug until [1]. Updating to the
latest v0.0.14 release fixes the issue.

Updating github.com/fatih/color as well while we're here.

[1] mattn/go-isatty#66
timoreimann added a commit to digitalocean/clusterlint that referenced this issue Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The
issue is our usage of github.com/mattn/go-isatty (consumed by
github.com/fatih/color) which had a bug until [1]. Updating to the
latest v0.0.14 release fixes the issue.

Also bump the minimum (library) dependency to 1.16 in go.mod since that
is the oldest, officially supported Go version. Bumping to 1.17 actually
enables us to fix the issue by simply updating to the latest
github.com/fatih/color, as opposed to adding an indirect import of
github.com/mattn/go-isatty which this change does right now (which I
suppose works due to Go 1.17 module management improvements); however,
that'd come at the price of breaking compatibility with 1.16 users which
is non-ideal.
Regardless, update github.com/fatih/color as well while we're here.

Also bump the version of the Go image used for testing.

[1] mattn/go-isatty#66
timoreimann added a commit to digitalocean/clusterlint that referenced this issue Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The
issue is our usage of github.com/mattn/go-isatty (consumed by
github.com/fatih/color) which had a bug until [1]. Updating to the
latest v0.0.14 release fixes the issue.

Also bump the minimum (library) dependency to 1.16 in go.mod since that
is the oldest, officially supported Go version. Bumping to 1.17 actually
enables us to fix the issue by simply updating to the latest
github.com/fatih/color, as opposed to adding an indirect import of
github.com/mattn/go-isatty which this change does right now (which I
suppose works due to Go 1.17 module management improvements); however,
that'd come at the price of breaking compatibility with 1.16 users which
is non-ideal.
Regardless, update github.com/fatih/color as well while we're here.

Also bump the version of the Go image used for testing.

[1] mattn/go-isatty#66
timoreimann added a commit to digitalocean/clusterlint that referenced this issue Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The
issue is our usage of github.com/mattn/go-isatty (consumed by
github.com/fatih/color) which had a bug until [1]. Updating to the
latest v0.0.14 release fixes the issue.

Also bump the minimum (library) dependency to 1.16 in go.mod since that
is the oldest, officially supported Go version. Bumping to 1.17 actually
enables us to fix the issue by simply updating to the latest
github.com/fatih/color, as opposed to adding an indirect import of
github.com/mattn/go-isatty which this change does right now (which I
suppose works due to Go 1.17 module management improvements); however,
that'd come at the price of breaking compatibility with 1.16 users which
is non-ideal.
Regardless, update github.com/fatih/color as well while we're here.

Also bump the version of the Go image used for testing.

[1] mattn/go-isatty#66
timoreimann added a commit to digitalocean/clusterlint that referenced this issue Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The
issue is our usage of github.com/mattn/go-isatty (consumed by
github.com/fatih/color) which had a bug until [1]. Updating to the
latest v0.0.14 release fixes the issue.

Also bump the minimum (library) dependency to 1.16 in go.mod since that
is the oldest, officially supported Go version. Bumping to 1.17 actually
enables us to fix the issue by simply updating to the latest
github.com/fatih/color, as opposed to adding an indirect import of
github.com/mattn/go-isatty which this change does right now (which I
suppose works due to Go 1.17 module management improvements); however,
that'd come at the price of breaking compatibility with 1.16 users which
is non-ideal.
Regardless, update github.com/fatih/color as well while we're here.

Also bump the version of the Go image used for testing.

[1] mattn/go-isatty#66
tklauser added a commit to tklauser/go-isatty that referenced this issue Sep 29, 2021
PR mattn#66 updated the golang.org/x/sys dependency in go.mod but didn't
update go.sum. This leads to the following error on running go.test.sh:

    go: golang.org/x/sys@v0.0.0-20210630005230-0f9fa26af87c: missing go.sum entry; to add it:
	go mod download golang.org/x/sys
    go: golang.org/x/sys@v0.0.0-20210630005230-0f9fa26af87c: missing go.sum entry; to add it:
	go mod download golang.org/x/sys

Fix this by running go mod download golang.org/x/sys && go mod tidy to
update and clean up go.sum.
tklauser added a commit to tklauser/go-isatty that referenced this issue Sep 29, 2021
PR mattn#66 updated the golang.org/x/sys dependency in go.mod but didn't
update go.sum. This leads to the following error on running go.test.sh:

    go: golang.org/x/sys@v0.0.0-20210630005230-0f9fa26af87c: missing go.sum entry; to add it:
    	go mod download golang.org/x/sys
    go: golang.org/x/sys@v0.0.0-20210630005230-0f9fa26af87c: missing go.sum entry; to add it:
    	go mod download golang.org/x/sys

Fix this by running go mod download golang.org/x/sys && go mod tidy to
update and clean up go.sum.
tklauser added a commit to tklauser/go-isatty that referenced this issue Oct 5, 2021
PR mattn#66 updated the golang.org/x/sys dependency in go.mod but didn't
update go.sum. This leads to the following error on running go.test.sh:

    go: golang.org/x/sys@v0.0.0-20210630005230-0f9fa26af87c: missing go.sum entry; to add it:
    	go mod download golang.org/x/sys
    go: golang.org/x/sys@v0.0.0-20210630005230-0f9fa26af87c: missing go.sum entry; to add it:
    	go mod download golang.org/x/sys

Fix this by running go get -u && go mod tidy to update golang.org/x/sys
and clean up go.sum.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants