Fix ListVolumes paging #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
fix-listvolumes-paging
branch
from
bcbe67b
to
7ddca9d
Compare
waynr
approved these changes
May 1, 2020
driver/controller.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| untypedVolumes := make([]interface{}, 0, len(volumes)) | ||
| for _, snap := range volumes { |
There was a problem hiding this comment.
I am a little confused by the use of snap here, it looks like we later cast to a godo.Volume. I'm guessing it's just a copy pasta error.
There was a problem hiding this comment.
Ah yes indeed -- good catch, it's fixed now.
timoreimann
force-pushed
the
fix-listvolumes-paging
branch
from
7ddca9d
to
d3280f1
Compare
adamwg
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
ListVolumesimplementation would ignore the starting token and max entries value from the request parameter, thereby effectively not using paging. This change provides a fix by refactoring the existing implementation forListSnapshotsinto a reusable helper method and using it from bothList*implementations.#300 introduced the fixed paging method for
ListSnapshots.