-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GetZoneByProviderID and GetZoneByNodeName #18
Comments
Did this fix the issue mentioned in #24 (comment) ? |
@klausenbusk this should have been fixed. What code are you referring to? |
This code: digitalocean-cloud-controller-manager/do/metadata.go Lines 28 to 30 in 9fbae98
digitalocean-cloud-controller-manager/do/cloud.go Lines 75 to 77 in f029698
Maybe I just don't understand the code :) |
The confusion there is how the Zones interface was designed. The GetZone method was originally for kubelets to get their own zones, usually using a meta data service. External cloud controllers have to adopt the same interfaces for compatibility. We technically don't even need to implement that method since it would never be called in our context, but it was used since GetZone was the only method at the time. In v1.8, GetZoneByProviderID and GetZoneByName were added which is what's really called by cloud controllers upstream. Before v1.8, this was considered a bug as per kubernetes/kubernetes#49308 |
Our implementation for GetZoneByProviderID and GetZoneByName https://github.com/digitalocean/digitalocean-cloud-controller-manager/blob/master/do/zones.go#L43-L70 And the only piece of code using the |
As per kubernetes/kubernetes#50926, DO CCM should implement those methods so we accurately represent the region of droplets instead of assuming droplets are in the same region as CCM.
The text was updated successfully, but these errors were encountered: