WIP - implement the k8s 1.8 Zones interface #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
reviewed
Sep 27, 2017
do/zones.go
Outdated
| // GetZoneByProviderID returns the Zone containing the current zone and | ||
| // locality region of the node specified by providerId. GetZoneByProviderID | ||
| // will only fill the Region field of cloudprovider.Zone for DO. | ||
| func (z zones) GetZoneByProviderID(providerID string) (cloudprovider.Zone, error) { |
There was a problem hiding this comment.
This is actually going to depend on some of the changes in #36
bhcleek
force-pushed
the
zones-k8s-1.8
branch
from
25ecc26
to
dfed670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to test this against a 1.8 cluster and rebase on top of #28, but would appreciate any early feedback.
Fixes #18