Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadbalancers: Support nodes where nodeName is the private or public IP #75

Merged
merged 1 commit into from Apr 14, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions do/common.go
Expand Up @@ -19,6 +19,8 @@ package do
import (
"fmt"

"k8s.io/api/core/v1"

"github.com/digitalocean/godo"
"github.com/digitalocean/godo/context"
)
Expand Down Expand Up @@ -56,3 +58,23 @@ func allDropletList(ctx context.Context, client *godo.Client) ([]godo.Droplet, e

return list, nil
}

// nodeAddresses returns a []v1.NodeAddress from droplet.
func nodeAddresses(droplet *godo.Droplet) ([]v1.NodeAddress, error) {
var addresses []v1.NodeAddress
addresses = append(addresses, v1.NodeAddress{Type: v1.NodeHostName, Address: droplet.Name})

privateIP, err := droplet.PrivateIPv4()
if err != nil || privateIP == "" {
return nil, fmt.Errorf("could not get private ip: %v", err)
}
addresses = append(addresses, v1.NodeAddress{Type: v1.NodeInternalIP, Address: privateIP})

publicIP, err := droplet.PublicIPv4()
if err != nil || publicIP == "" {
return nil, fmt.Errorf("could not get public ip: %v", err)
}
addresses = append(addresses, v1.NodeAddress{Type: v1.NodeExternalIP, Address: publicIP})

return addresses, nil
}
20 changes: 0 additions & 20 deletions do/droplets.go
Expand Up @@ -71,26 +71,6 @@ func (i *instances) NodeAddressesByProviderID(providerID string) ([]v1.NodeAddre
return nodeAddresses(droplet)
}

// nodeAddresses returns a []v1.NodeAddress from droplet.
func nodeAddresses(droplet *godo.Droplet) ([]v1.NodeAddress, error) {
var addresses []v1.NodeAddress
addresses = append(addresses, v1.NodeAddress{Type: v1.NodeHostName, Address: droplet.Name})

privateIP, err := droplet.PrivateIPv4()
if err != nil || privateIP == "" {
return nil, fmt.Errorf("could not get private ip: %v", err)
}
addresses = append(addresses, v1.NodeAddress{Type: v1.NodeInternalIP, Address: privateIP})

publicIP, err := droplet.PublicIPv4()
if err != nil || publicIP == "" {
return nil, fmt.Errorf("could not get public ip: %v", err)
}
addresses = append(addresses, v1.NodeAddress{Type: v1.NodeExternalIP, Address: publicIP})

return addresses, nil
}

// ExternalID returns the cloud provider ID of the droplet identified by
// nodeName. If the droplet does not exist or is no longer running, the
// returned error will be cloudprovider.InstanceNotFound.
Expand Down
13 changes: 13 additions & 0 deletions do/loadbalancers.go
Expand Up @@ -29,6 +29,7 @@ import (

"github.com/digitalocean/godo"
"github.com/digitalocean/godo/context"
"github.com/golang/glog"
)

const (
Expand Down Expand Up @@ -255,11 +256,23 @@ func (l *loadbalancers) nodesToDropletIDs(nodes []*v1.Node) ([]int, error) {

var dropletIDs []int
for _, node := range nodes {
Loop:
for _, droplet := range droplets {
if node.Name == droplet.Name {
dropletIDs = append(dropletIDs, droplet.ID)
break
}
addresses, err := nodeAddresses(&droplet)
if err != nil {
glog.Errorf("error getting node addresses for %s: %v", droplet.Name, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a continue here otherwise there would be a panic on the next for loop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, are you sure about the panic? The spec says For a nil slice, the number of iterations is 0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL :)

continue
}
for _, address := range addresses {
if address.Address == string(node.Name) {
dropletIDs = append(dropletIDs, droplet.ID)
break Loop
}
}
}
}

Expand Down