Resolve conflict with alert configurations by overriding command namespace #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
force-pushed
the
asb/APICLI-2259/alerts
branch
from
3e8e11c
to
c6427da
Compare
andrewsomething
force-pushed
the
asb/APICLI-2259/alerts
branch
2 times, most recently
from
d296744
to
2f07ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue with the
doctl monitoring alerts create/updatecommands introduced when we added the uptime alert commands. The way doctl's config file currently works, settings can only be three levels deep. This led to the alert commands conflicting with each other. For example, the configuration for thetypeflag for both ended up atalert.create.type.This PR resolves the problem adding a
cmdOptionto override the config namespace for a command without needing to change the sub-command layout. The monitoring alert config keeps its existing location (alert.create.<flag>) while the uptime alerts are now atuptime-alert.create.<flag>.