[VPC-3359] Implemented vpc peering methods #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfundaro-do
reviewed
May 17, 2024
ddatta-do
reviewed
May 17, 2024
ddatta-do
reviewed
May 17, 2024
viola
reviewed
May 17, 2024
Co-authored-by: ddatta-do <147642663+ddatta-do@users.noreply.github.com>
Co-authored-by: ddatta-do <147642663+ddatta-do@users.noreply.github.com>
Co-authored-by: ddatta-do <147642663+ddatta-do@users.noreply.github.com>
Co-authored-by: ddatta-do <147642663+ddatta-do@users.noreply.github.com>
Co-authored-by: ddatta-do <147642663+ddatta-do@users.noreply.github.com>
ddatta-do
reviewed
May 22, 2024
ddatta-do
approved these changes
May 22, 2024
bentranter
requested changes
May 28, 2024
There was a problem hiding this comment.
A few comments around documentation, and two larger design comments that I'll put here:
- I would prefer that the new command be under just
peeringsinstead ofvpc-peerings. Having it undervpc-peeringsmakes it repetitive to type out when invoking the command –doctl vpcs vpc-peerings --help, vs.doctl vpcs peerings --helpfor example. - For the
createsubcommand, both arguments are flags. For a create command indoctl, the more common pattern is for the name to be a positional argument, and then other arguments to be flags. This would mean the create command isdoctl vpcs peerings create <name> --vpc-ids <ids>instead.
(Pinging @andrewsomething and @danaelhe to see if they agree with the two design related points)
bentranter
approved these changes
May 30, 2024
AungkoMCM
reviewed
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VPC Peering is a closed beta feature and not available for public use.
Testing doc