Add monitoring flag #170
Merged
Add monitoring flag #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on digitalocean/godo#117
xmudrii
suggested changes
Dec 12, 2016
There was a problem hiding this comment.
You could add test but not required:
https://github.com/digitalocean/doctl/blob/master/commands/droplets_test.go#L69
added 2 commits
December 12, 2016 15:56
|
LGTM - want to merge and then vendor the updates in digitalocean/godo#117 and then merge? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on digitalocean/godo#117
Build should fail until PR above is merged and vendored code is updated.