[Fixes #168] Implementing command forwarding for external SSH #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmudrii
changed the title
|
Code looks good. Mind writing a test? |
|
@mdlayher Added test, how does it looks? |
|
lgtm! @grampajoe also gave it a 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we should fix #168. However, this is not really same idea as it's in issue.
Issue is proposing following implementation:
I decided to follow template of SSH unit, so I went with flag (
--ssh-command).When I execute
doctl compute ssh mydroplet, I'll work as usual.When I execute
doctl compute ssh test1 --ssh-command uptime, it'll will only return output of command, as expected:I want to know do you like it, how it looks and could it be done better.
Just to note, this is only implemented for external SSH (OS X & Linux). I need to look more in Windows implementation of SSH client, but first I want to know is this one OK. If this is right, I'll do the same for internal if possible.
cc @nanzhong @aybabtme