migrate from go dep to go modules #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilary
changed the title
- run `go mod init` - update k8s.io modules to versions support kubernetes-1.14.3 - remove go versions not supporting go modules from Travis - use go 1.12 for building - update developer docs - remove go dep files (Gopkg.*) - update vendor folder
hilary
changed the title
bhcleek
reviewed
Jun 20, 2019
| gopkg.in/inf.v0 v0.9.1 // indirect | ||
| gopkg.in/yaml.v2 v2.2.2 | ||
| k8s.io/api v0.0.0-20190606204050-af9c91bd2759 // indirect | ||
| k8s.io/apimachinery v0.0.0-20190404173353-6a84e37a896d |
There was a problem hiding this comment.
Is this the right k8s.io/apimachinery as of k8s.io/api@af9c91bd2759? If I had to guess, I'd say that you upgraded k8s.io/client-go last, and it upgraded k8s.io/api on you, too. Kubernetes packages should generally be kept inline with each other.
There was a problem hiding this comment.
Oddly, it is. The revision in Godeps.json matches.
bhcleek
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go mod init