Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile improvements #498

Merged
merged 3 commits into from Jul 18, 2019
Merged

Makefile improvements #498

merged 3 commits into from Jul 18, 2019

Conversation

hilary
Copy link
Contributor

@hilary hilary commented Jul 18, 2019

Edited CONTRIBUTING for clarity and flow.

bentranter
bentranter approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Am I correct in assuming that we're okay with leaving the installation instructions for mockery out of the #### godo mocks section for now, since I'm actively working on migrating to gomock?

@hilary
Copy link
Contributor Author

hilary commented Jul 18, 2019

We're leaving the installation instructions for mockery out of the #### godo mocks section for now because the script installs mockery for you, lol.

@bentranter
Copy link
Member

Oops, I was still thinking about your other branch where those had been removed from the script 🤦‍♂. Ok, merge away!

@hilary hilary merged commit abfc954 into digitalocean:master Jul 18, 2019
@hilary hilary deleted the makefile-improvements branch July 18, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentranter bentranter bentranter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hilary @bentranter