Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt shellcheck #502

Merged
merged 7 commits into from Jul 22, 2019
Merged

adopt shellcheck #502

merged 7 commits into from Jul 22, 2019

Conversation

hilary
Copy link
Contributor

@hilary hilary commented Jul 19, 2019

And do a bunch of cleanup 馃檮

https://github.com/koalaman/shellcheck

bentranter
bentranter approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@bentranter bentranter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bentranter bentranter merged commit ea62b1b into digitalocean:master Jul 22, 2019
@bentranter bentranter mentioned this pull request Jul 22, 2019
Merged
@hilary hilary deleted the shell_check branch July 22, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentranter bentranter bentranter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hilary @bentranter