Migrate from mockery to gomock #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the dependencies after the addition of gomock. Also tries to add the gomock binary "mockgen" through a tools.go file with a build tag.
Regenerates the mocks so that they match the mocks a user would generate exactly. They previously had a slight difference in formatting due to me running goimports on them on save.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
mockeryto generate the mock service implementations that we use in our command tests. This PR removesmockeryin favour ofgomock. There are several reasons we want to do this,gomockis actively maintained by the Go team, whilemockeryappears to be abandoned.gomocksupports Go modules, whilemockerydoes not. This allows to include gomock'smockgentool in our vendor folder via Go modules, which in turn lets us build the binary from the local vendor folder on each invocation of thescripts/regenmocks.shscript. To put it more simply, this lets us runmockgenwithout having to make the user install that binary themselves.gomockis used elsewhere at DO, so the switch is nice for consistency's sake.