Support kubernetes node pool labels #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
support-kubernetes-node-pool-labels
branch
from
21f5981
to
5ae86b2
Compare
timoreimann
commented
Jan 29, 2020
Verolop
reviewed
Jan 29, 2020
There was a problem hiding this comment.
LGTM
Adding @zachgersh as an additional reviewer, in case he has more feedback
Verolop
previously approved these changes
Jan 29, 2020
timoreimann
force-pushed
the
support-kubernetes-node-pool-labels
branch
2 times, most recently
from
30829d5
to
f074b73
Compare
timoreimann
force-pushed
the
support-kubernetes-node-pool-labels
branch
from
f074b73
to
e4837c1
Compare
|
PR has been updated to use godo v1.30.0 and should be ready for merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR depends on the latest (yet unreleased) master version of godo to set labels on Kubernetes requests. It is only meant to allow the PR to be shared and gather early feedback; the dependency will be reverted to the next godo release once it is out (and block merging until that has happend).(godo has been released and this PR updated accordingly.)