Simplify Docker build process and collapse on one file. #860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify Docker build process by collapsing it on one file. To do so, I first needed to allow overriding
GOARCH
in the Makefile.A few things to note:
make native
in favor ofmake build
. It was never truly native (just amd64 or 386), and as it now supports being overridden it makes less sense.make docker_build
, I copy out the resulting binary with/bin/cp
instead of rsync to remove the unneeded dependency.A few things to verify: