kubernetes: add support for optional cascading deletes #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshavaradarajan
force-pushed
the
varsha/support-optional-cascading-deletes
branch
from
c488d77
to
0492aea
Compare
There was a problem hiding this comment.
Looking good! A few nit picks inline, mostly around copy. We'd love to get an integration test as well.
https://github.com/digitalocean/doctl/blob/master/CONTRIBUTING.md#integration-tests
varshavaradarajan
force-pushed
the
varsha/support-optional-cascading-deletes
branch
2 times, most recently
from
0ff3cb6
to
11fd991
Compare
|
cc @sharmita3 |
sharmita3
reviewed
Jan 26, 2021
sharmita3
reviewed
Jan 26, 2021
sharmita3
reviewed
Jan 26, 2021
sharmita3
reviewed
Jan 26, 2021
sharmita3
reviewed
Jan 26, 2021
sharmita3
reviewed
Jan 26, 2021
MorrisLaw
reviewed
Jan 28, 2021
There was a problem hiding this comment.
Left a nit. Otherwise looks good after you address @sharmita3's comments.
varshavaradarajan
force-pushed
the
varsha/support-optional-cascading-deletes
branch
2 times, most recently
from
d521876
to
4a093f1
Compare
varshavaradarajan
force-pushed
the
varsha/support-optional-cascading-deletes
branch
from
4a093f1
to
71907d6
Compare
|
@andrewsomething - can you please 👍 and merge this? |
andrewsomething
requested changes
Jan 29, 2021
varshavaradarajan
force-pushed
the
varsha/support-optional-cascading-deletes
branch
3 times, most recently
from
3a89d68
to
5bd80e7
Compare
varshavaradarajan
force-pushed
the
varsha/support-optional-cascading-deletes
branch
from
5bd80e7
to
37f3519
Compare
varshavaradarajan
deleted the
varsha/support-optional-cascading-deletes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR vendors godo v1.57.0 and adds subcommands and flags to support optional cascading deletes for a Kubernetes cluster.
cc @adamwg , @MorrisLaw