Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle json null for QMP API generation #152

Merged
merged 7 commits into from
Oct 10, 2017
Merged

handle json null for QMP API generation #152

merged 7 commits into from
Oct 10, 2017

Conversation

JenniGriesmann
Copy link
Contributor

  • first commit is from @benlemasurier 's PR to ignore undocumented include statements
  • added some logic to handle the json "null" type that is now being used inside alternates in the schema
  • separate commit with the regenerated files using the updates above
  • added a function to try and figure out the QEMU version the schema file is coming from and print in a comment in the spec.txt file (This will only work if VERSION file exists in same directory as the schema; otherwise, it just prints UNKNOWN.)

benlemasurier and others added 6 commits September 14, 2017 21:32
@benlemasurier
internal/qmp-gen: followup to #146, ignore include
df72846 
 This extends support to ignore undocumented include statements.

 #146  added support to safely ignore the new pragma statement which did
 not include docstring. The schema has since been changed to commonly
 `include` without a docstring as well.

 Previously, code autogeneration was breaking with:

  invalid character '{' after top-level value exit status 1
@JenniGriesmann
special handling for json null type
5f07690
@JenniGriesmann
regenerate QMP API
754a62c
@JenniGriesmann
store QEMU spec version generated
8f6d628
@JenniGriesmann
QMP API generated isNullable cleanup
0693dbe
@JenniGriesmann
Fix golint / go fmt errors
05d214e
@benlemasurier
Copy link
Contributor

lgtm

@trapgate
Copy link
Member

+1. Just one suggestion: I would add a comment explaining the nullable types, since I'm not going to remember the details in a month or so. Nice work!

@JenniGriesmann JenniGriesmann merged commit 39453ac into master Oct 10, 2017
@JenniGriesmann JenniGriesmann deleted the handle_json_null branch October 10, 2017 16:46
suryatmodulus pushed a commit to suryatmodulus/go-qemu that referenced this pull request Oct 1, 2022
@connorkuehl
upgrade go-libvirt to latest revision (@8648fbd) (digitalocean#180)
85651f1 
This involves some additional changes to overcome breaking changes from
go-libvirt.

These are the new changes in this revision of go-libvirt since the last
release go-qemu has been using:

* remove invitation to empty IRC channel
* rpc_test: use Libvirt.addStream to add streams
* MockLibvirt: deep-copy response before adding ID
* monitor socket conn state in initLibvirtComms
* libvirttest: use atomic to read "serial"
* integration: wait for Disconnected before assert
* add CODEOWNERS
* Merge pull request digitalocean#152 from clarkwalcott/readme_update_rpc_link
* Docs: Update README with working link
* expose Libvirt.Disconnected method
* Add NetworkUpdateCompat
* update libvirt configuration step for new releases
* search generated include directory for header files
* ci updates (digitalocean#142)
* integration tests (digitalocean#141)
* take dialer as input instead of already existing connection (digitalocean#140)
* support authentication via polkit (digitalocean#138)
* fix some stream problems (digitalocean#137)
* Merge pull request digitalocean#136 from digitalocean/jenni/fix_potential_segfault
* write lock only needed for actual write
* rm unneeded nil'ing of reader and writer
* socket Disconnect close can race with nil of conn
* Merge pull request digitalocean#135 from digitalocean/jenni/update_cgo
* run go get golang.org/x/tools/go/internal/cgo@v0.1.1
* Merge pull request digitalocean#134 from digitalocean/jenni/add_socket_type
* change socket to pointer ref
* Merge branch 'master' of github.com:digitalocean/go-libvirt into jenni/add_socket_type
* Merge pull request digitalocean#133 from digitalocean/jenni/fix_event_unsubscribe_race
* reorder stream shutdown/delete
* fix race in disconnect of event stream cleanup
* add socket type to handle socket connection management
* Merge pull request digitalocean#132 from digitalocean/jenni/fix_client_deadlock
* fix typo and func conciseness
* move listen and cleanup into a func
* add timeout on waiting for disconnected
* move temporary read error check to a function
* Libvirt chan socketCleanupDone -> disconnected
* fix accidental go fmt of generated files
* add connect/disconnect to unit tests
* add tests for callback cleanup on connection disconnect
* fix rpc lookup test
* fix deadlocked clients on lack of libvirt response
* add more robust connection error checking
* Merge pull request digitalocean#131 from digitalocean/jenni/fix_invalid_test_data
* fix incorrect test data
* Merge pull request digitalocean#130 from digitalocean/jenni/stream_shutdown
* fix missing stream shutdown in lifecycle subscribe
* Merge pull request digitalocean#129 from digitalocean/geoff/vet-cleanup
* remove travis config file
* Clean up some linter errors
* Merge pull request digitalocean#125 from dmacvicar/dmacvicar_puberror
* Run generators against libvirt 7.2.0
* Unexport From* (ErrorDomain)
* golint
* go fmt
* libvirt.Error: expose only Code and Message
* Run generators against libvirt 7.1.0
* go fmt
* Make libvirtError public (libvirt.Error)
* github actions (digitalocean#128)
* internal/event/stream: fixes unsafe queue access (digitalocean#127)
* Merge pull request digitalocean#124 from sam-github/check-wrapped-errors
* Check wrapped errors for IsNotFound()
* Fix two race conditions related to Disconnect (digitalocean#120)
* Merge pull request digitalocean#119 from weizhouapache/readme-add-tls-port
* README: Add missing tls port in example
* README: Add example connect to libvirt via TLS over TCP (digitalocean#118)
* Add overload for Connect() to allow other libvirt drivers (digitalocean#117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlemasurier benlemasurier benlemasurier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JenniGriesmann @benlemasurier @trapgate