Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add digitalocean_domains data source #484

Merged
merged 3 commits into from
Sep 22, 2020

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Aug 24, 2020

Add a digitalocean_domains data source as the list version of digitalocean_domain. This data source is not as useful it could be since datalist does not support regex or substring matching yet.

@tdyas
Copy link
Contributor Author

tdyas commented Aug 24, 2020

If #481 lands first, then the FilterKeys and SortKeys fields will need to be deleted.

@andrewsomething
Copy link
Member

I've merged #481, so the FilterKeys and SortKeys fields can now be removed here too.

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somehow missed that you did the rebase here. Sorry for the long delay in merging.

@andrewsomething andrewsomething merged commit b9f79b9 into digitalocean:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants