This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
enhance(vmware): Add kickstart/firstboot handling #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds enhanced
vmnichandling in the Kickstart (Weasel) installer, and in the Firstboot network configuration.Introduces two new Params:
esxi/network-kickstart-vmnicesxi/network-firstboot-vmnicThese params take precedence over
esxi/vmnic-deviceif they are set. This allows VMware ESXi installations to start Kickstart install and switch to Firstboot configuration on different Physical NICs more cleanly.This code change is designed to support the complete transition from an installer (kickstart) NIC (eg
vmnic0) device, to a completely different physical NIC device (egvmnic1). As a part of this transition, it's necessary to destroy the associatedvmk0device invSwitch0, and recreate it, assigning the new physical NIC MAC address (egvmnic1) to thevmk0virtual switch port. Otherwise, ESXi assigns a dynamic randomly generated MAC address, which can cause confusion for DHCP operations.Limited support exists for "toggling" VMNIC assignments back and forth. For use of this feature in a non-standard "kickstart install, transition to firstboot configuration", you MUST set both of these new VMNIC devices to the correct current value, and newly requested vmnic device for the transition to succeed.
Existing Firstboot network configuration behaviors should not have been impacted or changed by this feature enhancement.