upgrade argument to install script is not working as expected with custom user/pass

[funkypenguin]

Hey guys!

I've been having some difficulty using the upgrade argument to the install script, alongside a custom user/password combination.

To reproduce:

Perform a fresh install with /tmp/provision-4.3.2/tools/install.sh --version=v4.3.2 --systemd install --drp-user=myuser --drp-password=mypass --remove-rocketskates

Output:

<snip>
    "Type": "dynamic",
    "Version": "v4.3.1",
    "Writable": false
  }
}
{
  "Available": true,
  "Bundle": "",
  "Description": "",
  "Endpoint": "",
  "Errors": [],
  "Meta": {},
  "Name": "myuser",
  "ReadOnly": false,
  "Roles": [
    "superuser"
  ],
  "Secret": "XO-Y7mS_xOMwuGTa",
  "Validated": true
}
{
  "Available": true,
  "Bundle": "",
  "Description": "",
  "Endpoint": "",
  "Errors": [],
  "Meta": {},
  "Name": "myuser",
  "ReadOnly": false,
  "Roles": [
    "superuser"
  ],
  "Secret": "jZ0VAZhHWhvWn35X",
  "Validated": true
}
Deleted user rocketskates

# Once dr-provision is started, setup a base discovery configuration
  drpcli bootenvs uploadiso sledgehammer
  drpcli prefs set defaultWorkflow discover-base unknownBootEnv discovery defaultBootEnv sledgehammer defaultStage discover

# Optionally, locally cache the isos for common community operating systems
  drpcli bootenvs uploadiso ubuntu-18.04-install
  drpcli bootenvs uploadiso centos-7-install

RS_KEY=myuser:mypass drpcli info get now works, but, even though I've removed the rocketskates user, RS_KEY=rocketskates:r0cketsk8ts drpcli info get will also work.

Further, if I then stop dr-provision, and run /tmp/provision-4.3.2/tools/install.sh --version=v4.3.2 --systemd upgrade --drp-user=myuser --drp-password=mypass, DRP successfully starts, but the install script errors with:

######### You can start the DigitalRebar Provision service with:
 systemctl daemon-reload &&  systemctl start dr-provision
######### You can enable the DigitalRebar Provision service with:
 systemctl daemon-reload &&  systemctl enable dr-provision
SAVING '/usr/local/bin/drpcli' to backup file (/usr/local/bin/drpcli.drp-installer.backup)
Install script saved to '/usr/local/bin/drp-install.sh'
(run ' /usr/local/bin/drp-install.sh remove' to uninstall DRP - must be root)
RS_KEY is myuser:mypass (this line was debugging I inserted - @funkypenguin)
DRP is not up yet, waiting (0) ...
DRP is not up yet, waiting (1) ...
DRP is not up yet, waiting (2) ...
DRP is not up yet, waiting (3) ...
DRP is not up yet, waiting (4) ...
DRP is not up yet, waiting (5) ...
DRP is not up yet, waiting (6) ...
DRP is not up yet, waiting (7) ...
DRP is not up yet, waiting (8) ...
DRP is not up yet, waiting (9) ...
DRP is not up yet, waiting (10) ...
EXIT MESSAGE: FATAL: DRP Failed to start
(reverse-i-search)`remove': /tmp/provision-4.3.2/tools/install.sh --version=v4.3.2 --systemd upgrade --drp-user=myuser --drp-password=mypass --^Cmove-rocketskates
root@banana:~#

And journalctl -u dr-provision shows me:

Jun 23 11:52:46 banana dr-provision[30821]: [108:22]Failed Authenticated (no user) user myuser from 127.0.0.1

For now I'm falling back to using the install command, rather than upgrade, since that still seems to work.

Cheers!
D