[pull] master from tmux-python:master #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
- Coverage 75.51% 75.23% -0.28%
==========================================
Files 8 8
Lines 1168 1175 +7
Branches 295 299 +4
==========================================
+ Hits 882 884 +2
- Misses 205 210 +5
Partials 81 81
Continue to review full report at Codecov.
|
tony
force-pushed
the
master
branch
2 times, most recently
from
a377fff
to
ae6c0eb
Compare
tony
force-pushed
the
master
branch
5 times, most recently
from
eb9e5f9
to
67013a1
Compare
tony
force-pushed
the
master
branch
9 times, most recently
from
a284a92
to
28b72ef
Compare
tony
force-pushed
the
master
branch
2 times, most recently
from
72b3890
to
cac8807
Compare
tony
force-pushed
the
master
branch
2 times, most recently
from
5cd97e9
to
b7d8c24
Compare
tony
force-pushed
the
master
branch
4 times, most recently
from
1298511
to
be197a9
Compare
ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes --ignore T201 --ignore F401 --ignore PT014 --ignore RUF100 --ignore PGH004; ruff format .
Fixed 102 errors:
- conftest.py:
1 × UP031 (printf-string-formatting)
1 × UP032 (f-string)
- docs/_ext/aafig.py:
3 × UP031 (printf-string-formatting)
3 × UP032 (f-string)
- docs/conf.py:
2 × UP031 (printf-string-formatting)
- src/tmuxp/cli/convert.py:
1 × UP031 (printf-string-formatting)
1 × UP032 (f-string)
- src/tmuxp/cli/debug_info.py:
19 × UP031 (printf-string-formatting)
8 × UP032 (f-string)
- src/tmuxp/cli/freeze.py:
5 × UP031 (printf-string-formatting)
4 × UP032 (f-string)
- src/tmuxp/cli/import_config.py:
4 × UP031 (printf-string-formatting)
4 × UP032 (f-string)
1 × EM103 (dot-format-in-exception)
- src/tmuxp/cli/load.py:
2 × UP031 (printf-string-formatting)
1 × UP032 (f-string)
- src/tmuxp/cli/utils.py:
3 × UP031 (printf-string-formatting)
2 × UP032 (f-string)
- src/tmuxp/workspace/finders.py:
2 × UP031 (printf-string-formatting)
2 × UP032 (f-string)
- src/tmuxp/workspace/importers.py:
1 × UP031 (printf-string-formatting)
- tests/workspace/test_config.py:
8 × UP031 (printf-string-formatting)
8 × UP032 (f-string)
- tests/workspace/test_finder.py:
8 × UP031 (printf-string-formatting)
8 × UP032 (f-string)
src/tmuxp/workspace/finders.py:194:89: E501 Line too long (97 > 88) src/tmuxp/workspace/finders.py:210:89: E501 Line too long (103 > 88)
ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes --ignore T201 --ignore F401 --ignore PT014 --ignore RUF100; ruff format .
Fixed 29 errors:
- conftest.py:
1 × UP037 (quoted-annotation)
- src/tmuxp/_internal/config_reader.py:
1 × UP037 (quoted-annotation)
- src/tmuxp/cli/convert.py:
1 × UP037 (quoted-annotation)
- src/tmuxp/cli/debug_info.py:
3 × COM812 (missing-trailing-comma)
- src/tmuxp/cli/freeze.py:
1 × UP037 (quoted-annotation)
1 × COM812 (missing-trailing-comma)
- src/tmuxp/cli/load.py:
1 × COM812 (missing-trailing-comma)
- src/tmuxp/plugin.py:
1 × UP037 (quoted-annotation)
- src/tmuxp/shell.py:
6 × PGH004 (blanket-noqa)
- src/tmuxp/util.py:
1 × PGH004 (blanket-noqa)
- src/tmuxp/workspace/builder.py:
1 × UP037 (quoted-annotation)
- tests/fixtures/pluginsystem/partials/all_pass.py:
1 × UP037 (quoted-annotation)
- tests/fixtures/pluginsystem/partials/libtmux_version_fail.py:
3 × UP037 (quoted-annotation)
- tests/fixtures/pluginsystem/partials/tmux_version_fail.py:
3 × UP037 (quoted-annotation)
- tests/fixtures/pluginsystem/partials/tmuxp_version_fail.py:
3 × UP037 (quoted-annotation)
- tests/fixtures/pluginsystem/plugins/tmuxp_test_plugin_fail/tmuxp_test_plugin_fail/plugin.py:
1 × UP037 (quoted-annotation)
I do not think this handled the solution surgically, it seems to force losing safety for the rule across a *whole file* rather than surgically at the offending line. See also: python/mypy#12076, python/mypy#13512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )