if a datavalue is null, then test the return behavior

openapi/resource_factory.go

@@ -341,7 +341,7 @@ func (r resourceFactory) handlePollingIfConfigured(responsePayload *map[string]i
 		if ok {
 			*responsePayload = remoteDataCasted
 		} else {
-			return fmt.Errorf("failed to convert remote data (%s) to map[string]interface{}", reflect.TypeOf(remoteData)) //untested
+			return fmt.Errorf("failed to convert remote data (%s) to map[string]interface{}", reflect.TypeOf(remoteData))
 		}
 	}
 	return nil
@@ -600,7 +600,7 @@ func (r resourceFactory) createPayloadFromLocalStateData(resourceLocalData *sche
 
 func (r resourceFactory) getPropertyPayload(input map[string]interface{}, property *specSchemaDefinitionProperty, dataValue interface{}) error {
 	if dataValue == nil {
-		return fmt.Errorf("property '%s' has a nil state dataValue", property.Name) //untested
+		return fmt.Errorf("property '%s' has a nil state dataValue", property.Name)
 	}
 	dataValueKind := reflect.TypeOf(dataValue).Kind()
 	switch dataValueKind {

openapi/resource_factory_test.go

@@ -860,6 +860,7 @@ func TestHandlePollingIfConfigured(t *testing.T) {
 				},
 				returnHTTPCode: http.StatusOK,
 			}
+
 			responsePayload := map[string]interface{}{}
 
 			responseStatusCode := http.StatusAccepted
@@ -918,7 +919,7 @@ func TestHandlePollingIfConfigured(t *testing.T) {
 				responses: map[int]*specResponse{},
 			}
 			err := r.handlePollingIfConfigured(nil, resourceData, client, operation, responseStatusCode, schema.TimeoutCreate)
-			Convey("Then the err returned should be nil", func() {
+			Convey("Then the err  should be nil", func() {
 				So(err, ShouldBeNil)
 			})
 		})
@@ -1841,6 +1842,14 @@ func TestGetPropertyPayload(t *testing.T) {
 		So(func() { resourceFactory.getPropertyPayload(input, nil, dataValue) }, ShouldPanic)
 	})
 
+	Convey("Given a resource factory"+
+		"When getPropertyPayload is called with a nil datavalue"+
+		"Then it returns an error", t, func() {
+		input := map[string]interface{}{}
+		resourceFactory := resourceFactory{}
+		So(resourceFactory.getPropertyPayload(input, &specSchemaDefinitionProperty{Name: "buu"}, nil).Error(), ShouldEqual, `property 'buu' has a nil state dataValue`)
+	})
+
 	Convey("Given a resource factory"+
 		"When it is called with  non-nil property and value for dataValue which cannot be cast to []interface{}"+
 		"Then it panics", t, func() {
@@ -2109,6 +2118,7 @@ func TestGetPropertyPayload(t *testing.T) {
 			So(err.Error(), ShouldEqual, "something is really wrong here...an object property with nested objects should have exactly one elem in the terraform state list")
 
 		})
+
 		Convey("When getPropertyPayload is called with an empty map, the property with nested object in the resource schema and it's corresponding terraform resourceData state data value", func() {
 			payload := map[string]interface{}{}
 			dataValue, _ := resourceData.GetOkExists(propertyWithNestedObject.getTerraformCompliantPropertyName())