Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotuner broken for bfast #1269

Closed
Munksgaard opened this issue Mar 12, 2021 · 5 comments · Fixed by #1270
Closed

Autotuner broken for bfast #1269

Munksgaard opened this issue Mar 12, 2021 · 5 comments · Fixed by #1270

Comments

@Munksgaard
Copy link
Collaborator

I think this is caused by the new pretty-printer inserting newlines in the output of --print-sizes. The regex that looks for sizes will fail given the inserted newlines.

New:

[jxk588@gpu04:~/src/futhark]$ futhark-master opencl futhark-benchmarks/rodinia/lud/lud.fut && ./futhark-benchmarks/rodinia/lud/lud --print-sizes
[...]
main.suff_intra_par_14 (threshold([!main.suff_outer_par_13], 32))
main.suff_intra_par_20 (threshold([], 32))
main.suff_intra_par_22 (threshold([!main.suff_intra_par_20], 32))
main.suff_intra_par_6 (threshold([], 32))
main.suff_intra_par_8 (threshold([!main.suff_intra_par_6], 32))
main.suff_outer_par_13 (threshold([]))
main.suff_outer_par_15 (threshold([!main.suff_outer_par_13, !main.suff_intra_par_14]))
main.suff_outer_par_16 (threshold([!main.suff_outer_par_15, !main.suff_outer_par_13,
           !main.suff_intra_par_14]))
main.suff_outer_par_17 (threshold([!main.suff_outer_par_16, !main.suff_outer_par_15,
           !main.suff_outer_par_13, !main.suff_intra_par_14]))

Old:

[jxk588@gpu04:~/src/futhark]$ futhark-0.19.1 opencl futhark-benchmarks/rodinia/lud/lud.fut && ./futhark-benchmarks/rodinia/lud/lud --print-sizes
[...]
main.suff_intra_par_14 (threshold (!main.suff_outer_par_13))
main.suff_intra_par_20 (threshold ())
main.suff_intra_par_22 (threshold (!main.suff_intra_par_20))
main.suff_intra_par_6 (threshold ())
main.suff_intra_par_8 (threshold (!main.suff_intra_par_6))
main.suff_outer_par_13 (threshold ())
main.suff_outer_par_15 (threshold (!main.suff_outer_par_13 !main.suff_intra_par_14))
main.suff_outer_par_16 (threshold (!main.suff_outer_par_15 !main.suff_outer_par_13 !main.suff_intra_par_14))
main.suff_outer_par_17 (threshold (!main.suff_outer_par_16 !main.suff_outer_par_15 !main.suff_outer_par_13 !main.suff_intra_par_14))
@Munksgaard
Copy link
Collaborator Author

Munksgaard commented Mar 12, 2021

I think the offending commit is 70e8bda c0c5d25

@athas
Copy link
Member

athas commented Mar 12, 2021

Oh yes, it's too easy to accidentally prettyprint lists. This should use spread instead.

Munksgaard added a commit that referenced this issue Mar 12, 2021
Otherwise autotune stops working.

Fixes #1269
@Munksgaard Munksgaard reopened this Mar 12, 2021
@Munksgaard
Copy link
Collaborator Author

Munksgaard commented Mar 12, 2021

Ugh, it's not that simple....

main.suff_intra_par_10(threshold(, 32))

vs

main.suff_intra_par_10 (threshold ())

@athas
Copy link
Member

athas commented Mar 12, 2021

You need to fix the auto-tuner. Although that printing format isn't exactly great...

@athas
Copy link
Member

athas commented Mar 14, 2021

I'm working on this.

@athas athas closed this as completed in b02ffdf Mar 14, 2021
philass pushed a commit that referenced this issue Apr 10, 2021
Otherwise autotune stops working.

Fixes #1269
philass pushed a commit that referenced this issue Apr 10, 2021
Munksgaard added a commit to Munksgaard/futhark-autotuning-tfp21 that referenced this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants