Restrict index functions to a single LMAD #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razetime
pushed a commit
to razetime/futhark
that referenced
this pull request
Jul 16, 2023
This simplifies the memory IR. Whenever we encounter an index space transformation that we cannot represent as a single LMAD, we linearise to row-major order and try again. This is not fundamentally different from the old behaviour, where multi-LMAD index functions also forced linearisation at most forms of control flow. I do expect we'll be chasing consequences of this change for some time, but it seems to have no impact on benchmarks. Closes diku-dk#1705.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.