Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to extend plugins by array or function #267

Merged
merged 2 commits into from
Jul 4, 2021
Merged

Allow to extend plugins by array or function #267

merged 2 commits into from
Jul 4, 2021

Conversation

techhead
Copy link
Contributor

I don't always just want to add a plugin to the end.

@patricklafrance
Copy link
Contributor

Thanks for the PR.

Could you also update the documentation please.

@techhead
Copy link
Contributor Author

Ok, there wasn't a lot to begin with. I added a line.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 2, 2021
@techhead
Copy link
Contributor Author

techhead commented Jun 2, 2021

Any objection with incorporating this?

@stale stale bot removed the wontfix label Jun 2, 2021
@opii972
Copy link
Contributor

opii972 commented Jul 2, 2021

I'm not sure to undestand why it's necessary. Do you have a concrete example ?

@techhead
Copy link
Contributor Author

techhead commented Jul 2, 2021

I'm not sure to undestand why it's necessary. Do you have a concrete example ?

Yes, it's right there in my first comment. "I don't always just want to add a plugin to the end."

And in the examples I added to the documentation.

My change allows you to prepend a plugin when plugin order matters (or even to insert).

@patricklafrance patricklafrance merged commit 6fe8a3b into dilanx:master Jul 4, 2021
@patricklafrance
Copy link
Contributor

Thanks, released in https://www.npmjs.com/package/@craco/craco/v/6.2.0

@induratized
Copy link

@techhead can you add the link to doc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants