Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix signature for whenXX functions #468

Merged
merged 1 commit into from Nov 13, 2022
Merged

fix signature for whenXX functions #468

merged 1 commit into from Nov 13, 2022

Conversation

liao02x
Copy link
Contributor

@liao02x liao02x commented Nov 10, 2022

The signature for when function is when(condition, fn, [unmetValue]), and the signature for whenXX functions should be just when(fn, [unmetValue])

@liao02x
fix signature for whenXX functions
c64f10a 
The signature for when function is when(condition, fn, []), and the signature for whenXX functions should be just when(fn, [])
@liao02x liao02x requested a review from dilanx as a code owner November 10, 2022 08:15
dilanx
dilanx approved these changes Nov 13, 2022
View reviewed changes
Copy link
Owner

@dilanx dilanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@dilanx dilanx merged commit 4e7e363 into dilanx:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilanx dilanx dilanx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liao02x @dilanx