-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement from schema file feature #247
Implement from schema file feature #247
Conversation
I'm getting a weird error regarding the graphql dependency. It is only working if I set the Error:
|
@dillonkearns I don't think there is a way to fix this because it seems an error related to parcel minification. So, we have 2 options, remove the minification temporary or wait for some fix from them. what do you think about it? |
Hey! I'm all for removing the minification. The only thing is that it uses Typescript, and it imports Elm code. So we need some sort of build process. Would it work to compile it in dev mode but still use parcel? Otherwise I imagine it would be a lot of work to set up a streamlined build process. Thanks for working on this! |
@dillonkearns yeah, parcel has an argument to remove the minification I have to thank you to create such a useful library :D |
Nice, glad that solved it! Another thought (for a future request) is that it might be nice to remove those flags entirely and just have the argument infer what to do with it from context. For example, if it starts with Thanks for contributing this! I'll just check it out and make sure everything looks good before pushing merging this in. Thank you! |
Yeah, I think it make sense make it more user-friendly, I will give a try next week to play with it, as we are using in my company, I will be glad to help to improve it :D |
Hello @jouderianjr, that would be great, let me know if you need any help on that change! I pushed some code to move things to 0.19.1 since there were some build issues around that, and I've got it to a green build now (sorry for the git diff noise). I'll merge this in and ship it. Thanks again for your contribution! 🙏 |
Hey Dillon, as we discussed some months ago in my company we used to generate the elm files based on a shared schema file, not from the introspection file. So, this pr adds
schema-file
options.I can add in the future a feature to fetch the file from a remote server.